Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive naming schema for Precomputed #94

Open
2 tasks
MaxDall opened this issue Mar 15, 2023 · 0 comments
Open
2 tasks

More descriptive naming schema for Precomputed #94

MaxDall opened this issue Mar 15, 2023 · 0 comments
Labels
enhancement Improvements upon existing features.

Comments

@MaxDall
Copy link
Collaborator

MaxDall commented Mar 15, 2023

Currently the Precomputed class consists of very overloaded names while itself yielding not much information about it's nature through the class name:

class Precomputed:
    html: str
    doc: lxml.html.HtmlElement
    meta: Dict[str, str]
    ld: LinkedData
    cache: Dict[str, Any] = field(default_factory=dict)

The goal of this issue is:

  • Find a new name for class Precomputed as well as the precomputed attribute of BaseParser
  • Find more precise names for ld, doc, meta

The above list also include renaming those instances and this issue should be closed with a PR

@MaxDall MaxDall added the enhancement Improvements upon existing features. label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements upon existing features.
Projects
None yet
Development

No branches or pull requests

1 participant