-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Found Code Connect Swift package" step finding incorrect location with Swift Package Manager #140
Comments
Hi @jordikitto, thanks for bringing this to our attention -- Looks like there's some cases that finding the checkout of code-connect doesn't cover completely. Would you be willing to share what the output of running xcodebuild -project .xcodeproj -showBuildSettings locally is for you, and how you're adding the package to your project? That would help to determine a proper solution. Workaround wise, as you've identified you can add a symlink in order to trick the parser to finding the right location. Another option is to create a dummy |
Hi @jyyang0 Here is the output of As for the project structure, it looks like such:
The package is added to the project like so:
The package is added to the
This all builds successfully, with a If it makes any difference, I open the "project" via the |
Hey @jyyang0, any updates on this one? Would be really great if we could integrate this into our CI for our large project but this is making it quite difficult :( |
Sorry about the delay -- Looking at your setup it seems like our current system is making some assumptions about xcodeproj based workspaces. which is failing -- In the next release that's coming out (1.0.7) we've added the ability to specify a This isn't a perfect solution and we're still iterating on how we can make the system more robust as a whole to support a variety of xcode project configurations, but this feedback is really helpful! |
Hi,
When running
figma connect
commands in my Xcode project root directory, I get the following:It fails because
code-connect
is not checked out to this location. I am using Swift Package Manager (SPM) and the actual location is:Looking at your implementation, I see the following steps are occurring:
xcodeProjFile
is being defined viagetFileIfExists(cwd, '*.xcodeproj')
xcodebuild -project ${xcodeProjFile} -showBuildSettings
is being run to determine:BUILD_DIR
is (/Users/jordikitto/Repos/<project>/build
)/Users/jordikitto/Repos/<project>/build/../../SourcePackages/checkouts/code-connect
Again, unfortunately, this path is not the correct location. The correct location is in the DerivedData folder located above.
From my understanding, this is because of Swift Package Manager checking out the repo? Does Code Connect support SPM installation? If not, what is the correct way to use Code Connect with Xcode projects/workspaces?
Happy to provide any further details.
--
I did manage to get Code Connect to work with a hack symbolic link, for reference:
Please provide:
1.0.6
The text was updated successfully, but these errors were encountered: