chore: send logs query param to status request as true by default

[chamini2]

We are making getting the logs during a status request optional. So enabling this to get them (or not) as necessary.

closes FEA-1645

[linear]

FEA-1645 Make getting logs from the status endpoint optional

[drochetti]

Cool, thanks for doing this!

The question I have is, if the logs are disabled, does the queue status payload still contain an empty logs property? Or is it missing or null?

Asking because queue status is defined like this, with logs always present in case it's IN_PROGRESS or COMPLETED, so is this still correct?

export type QueueStatus =
  | {
      status: 'IN_PROGRESS' | 'COMPLETED';
      response_url: string;
      logs: RequestLog[];
    }
  | {
      status: 'IN_QUEUE';
      queue_position: number;
      response_url: string;
    };

[drochetti]

Ah, another recommendation I have is to add the option to the fal.subscribe which encapsulates the queue usage, with long polling, etc. So you could add a logs: boolean in the SubscribeOptions type in here https://github.com/fal-ai/serverless-js/blob/0e3cb8593916eeb024a9896c6c7339c9821b3330/libs/client/src/function.ts#L161-L179

Related to that, is the idea to keep as true by default? I thought at first the idea was to add logs only on demand.

[chamini2]

Related to that, is the idea to keep as true by default? I thought at first the idea was to add logs only on demand.

I just wanted to make our client more backwards compatible. I can do whichever

[drochetti]

Related to that, is the idea to keep as true by default? I thought at first the idea was to add logs only on demand.

I just wanted to make our client more backwards compatible. I can do whichever

got it! I think if the idea is to make logs only available on demand, we can make it false by default since the main user in production relying on logs right now is our own web-app and there it's pinned to a specific version. So when we launch a new version, the web-app will have to upgrade and then can pass true. Wdyt?

[drochetti]

Awesooome 🚀