Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kMaxPageSize adaptive #11043

Open
Yuhta opened this issue Sep 19, 2024 · 0 comments
Open

Make kMaxPageSize adaptive #11043

Yuhta opened this issue Sep 19, 2024 · 0 comments
Labels
enhancement New feature or request performance

Comments

@Yuhta
Copy link
Contributor

Yuhta commented Sep 19, 2024

Description

Currently there is a threshold (10000) on limit to let partial limit query not buffering page data to accelerate these small queries. There is some attempt (#10909) to make this limit configurable. However after discussion, we think a better solution is to make kMaxPageSize adaptively increasing from a small number, so that no magic number needs to be configured in engine to accommodate both small limit and large streaming use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

1 participant