Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Tutorial Edits #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonathanLorimer
Copy link

I was reading the tutorial, and figured I would keep track of any typos I saw. Hopefully this is helpful. I know that import alignment can be contentious, I opted to unify anomalous examples with the most common style for consistency (but I can revert this if desired).

@JonathanLorimer
Copy link
Author

JonathanLorimer commented Jul 5, 2021

I am not really sure why this is failing CI, when I try to run stack install I get an error about the github attribute in the simple-storage subdirectory:

λ stack install hlint stylish-haskell
Warning: /home/jonathanl/Code/kepler.git/documentation-fixes/stack.yaml: Unrecognized field in ProjectAndConfigMonoid: explicit-setup-deps
/home/jonathanl/Code/kepler.git/documentation-fixes/hs-abci-docs/simple-storage/package.yaml: Error while parsing $.github - expected owner/repo or owner/repo/subdir, but encountered "f-o-a-m/kepler/hs-abci-docs/simple-storage"
λ stack --version
2.7.1 x86_64 hpack-0.34.4

@alexfmpe
Copy link
Contributor

alexfmpe commented Jul 6, 2021

I am not really sure why this is failing CI, when I try to run stack install I get an error about the github attribute in the simple-storage subdirectory

hpack bugs: #245 (comment)

@JonathanLorimer
Copy link
Author

JonathanLorimer commented Jul 6, 2021

@alexfmpe I am pretty sure that the package.yaml doesn't have the http prefix

expected owner/repo or owner/repo/subdir, but encountered "f-o-a-m/kepler/hs-abci-docs/simple-storage"

@alexfmpe
Copy link
Contributor

alexfmpe commented Jul 6, 2021

It doesn't, that's why #245 didn't 'fix it' and instead linked to the upstream issue

@JonathanLorimer
Copy link
Author

Ahh, I see. Thanks for pointing that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants