Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not overwrite search query when input is focused #132

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

evadecker
Copy link
Owner

@evadecker evadecker commented Nov 22, 2023

  • Sometimes multiple goto calls could be made independently and resolve after the user had typed, resulting in text being overwritten in the input
  • This checks if the search isFocused before making any changes to user input
  • Thanks @paoloricciuti for the fix!
  • Sets replaceState: true on search-related goto() calls in order to prevent the browser's back button from capturing and replaying debounced search queries

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
genderswap-fm ✅ Ready (Inspect) Visit Preview Nov 22, 2023 6:35pm

@evadecker evadecker merged commit e67395d into main Nov 22, 2023
2 checks passed
@evadecker evadecker deleted the fix-search-debounce-overwriting branch November 22, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant