Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting genesis inbox contract as a first step #11821

Open
blockchaindevsh opened this issue Sep 10, 2024 · 0 comments
Open

Supporting genesis inbox contract as a first step #11821

blockchaindevsh opened this issue Sep 10, 2024 · 0 comments

Comments

@blockchaindevsh
Copy link

blockchaindevsh commented Sep 10, 2024

Previously I submitted a proposal for inbox contract here, it turns out the diff will be too big for FP if we want to support dynamic updates.

Instead I think we can support genesis inbox contract as a first step, which only requires minimal changes:

  1. The BatchInboxAddress can now be set to either an Externally Owned Account (EOA) or a smart contract. When a contract is used, it assumes responsibility for verifying and enforcing batch submission conditions.
  2. Modification of the op-node derivation process: The op-node will be updated to exclude failed batch transactions during the derivation process. This change ensures that only successfully executed batch transactions are processed and included in the derived state.
  3. Modification of the op-batcher submission process: The op-batcher will be updated to call recordFailedTx for failed batch transactions. This modification ensures that the data contained in failed transactions will be resubmitted automatically.
    1. Most failures will be detected during the EstimateGas call. However, under certain race conditions, failures may occur after the transaction has been included in a block.

(extracted from the original proposal)

We've deployed the genesis inbox contract feature and tested sufficiently in our devnet/testnet .

This approach seems to align with the current practices of other rollups. We could defer implementation of dynamic inbox contracts to future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant