fix overlays being cut off from the top #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overlays were always positioned at y=0 and the y pos was cut off from the top part of the buffer this was an issue since: fdbf0bf (Graphics.drawImages layer x/y can now be non-integer (smoother movement on scaled/rotated images), 2024-05-22)
This was referenced Jun 22, 2024
|
Thanks for tracking this down - that's great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, overlays were always positioned at y=0 and the y pos was cut off from the top part of the buffer.
That behaviour was introduced by: fdbf0bf
Since that commit, the coordinates of a
GfxDrawImageLayerwere changed to be the position in pixels, multiplied by 256.The overlay y position now has to be multiplied by 256 as well, before assigning it to the y start coordinate of a
GfxDrawImageLayer.Closes #2520 (See that issue for screenshots and some more info.)