You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but that would revert part of 5a99fbd
I've got absolutely no idea when partial updates happen, but I guess moving that iterator call inside the for loop would probably break something else ¯\_(ツ)_/¯
The text was updated successfully, but these errors were encountered:
I did some more digging:
Since fdbf0bf changed the positions of a GfxDrawImageLayer to be the value in pixels, shifted to the left by 8 bits, we need to shift the desired overlay y position by 8 bits before assigning it to the GfxDrawImageLayer's y1.
I did just that in #2521, and it looks like that did the trick :)
I completely forgot that overlay positions can be negative 😅
Multiplying the pixel position by 256 (which I did in #2522) is probably a lot more readable anyways.
Overlays are being cut off from the top, by about as many pixels as their y position should be, instead of landing at the desired y position.
To reproduce on a Bangle.js 2 (code copied from the docs about overlays):
Expected outcome:
Actual outcome:
A git bisect, using the emulator, leads to this being the first bad commit: fdbf0bf
Moving the following line inside the for loop above it seems to fix things
Espruino/libs/graphics/lcd_memlcd.c
Line 347 in 31c5d60
but that would revert part of 5a99fbd
I've got absolutely no idea when partial updates happen, but I guess moving that iterator call inside the for loop would probably break something else ¯\_(ツ)_/¯
The text was updated successfully, but these errors were encountered: