Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should esp-wifi take ownership of ADC2? #2150

Open
Frostie314159 opened this issue Sep 12, 2024 · 0 comments
Open

Should esp-wifi take ownership of ADC2? #2150

Frostie314159 opened this issue Sep 12, 2024 · 0 comments
Labels
chip:esp32 Issue related to ESP32 chip package:esp-wifi Issues related to the esp-wifi package

Comments

@Frostie314159
Copy link
Contributor

Motivations

On the ESP32, you can't use the ADC2 peripheral, during Wi-Fi operations, which the current API, this is still possible.

Solution

Make esp-wifi take ownership of ADC2 when starting the stack.

Alternatives

@MabezDev suggested detecting this, and panicking, if the user tries to use ADC2, while Wi-Fi is active, since this is only a requirement on the ESP32.

Additional context

@Frostie314159 Frostie314159 added the status:needs-attention This should be prioritized label Sep 12, 2024
@MabezDev MabezDev added package:esp-wifi Issues related to the esp-wifi package chip:esp32 Issue related to ESP32 chip labels Sep 12, 2024
@jessebraham jessebraham added chip:esp32 Issue related to ESP32 chip and removed status:needs-attention This should be prioritized chip:esp32 Issue related to ESP32 chip labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chip:esp32 Issue related to ESP32 chip package:esp-wifi Issues related to the esp-wifi package
Projects
Status: Todo
Development

No branches or pull requests

3 participants