From 4ae5e11131ec8f537369c3374c39f777287f3f4a Mon Sep 17 00:00:00 2001 From: Alex Sharov Date: Thu, 18 Apr 2024 10:13:21 +0700 Subject: [PATCH 1/2] golangci-lint v1.57.2 (#66) --- .github/workflows/go-checks.yml | 2 +- Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/go-checks.yml b/.github/workflows/go-checks.yml index b370642..4c1585e 100644 --- a/.github/workflows/go-checks.yml +++ b/.github/workflows/go-checks.yml @@ -17,7 +17,7 @@ jobs: - run: go mod tidy - uses: golangci/golangci-lint-action@v4 with: - version: 'v1.56' + version: 'v1.57' skip-pkg-cache: true - run: go build -v ./... - run: go test -v ./... diff --git a/Makefile b/Makefile index 0b77de1..a5e91e4 100644 --- a/Makefile +++ b/Makefile @@ -38,6 +38,6 @@ lintci: ## lintci-deps: (re)installs golangci-lint to build/bin/golangci-lint lintci-deps: rm -f ./build/bin/golangci-lint - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./build/bin v1.56.1 + curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./build/bin v1.57.2 .PHONY: build test run clean \ No newline at end of file From 12190a8a39a233dd478afcc17bd0ae596e3adab4 Mon Sep 17 00:00:00 2001 From: Alex Sharov Date: Thu, 18 Apr 2024 16:02:01 +0700 Subject: [PATCH 2/2] Golangci lint up (#67) * golangci-lint v1.57.2 * save * save * save * save --- .golangci.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index df6ae94..fa9697a 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,5 +1,5 @@ run: - deadline: 10m + timeout: 10m linters: presets: @@ -41,7 +41,6 @@ linters-settings: # By default list of stable checks is used. enabled-checks: # - ruleguard - - truncateCmp # - defaultCaseOrder # Which checks should be disabled; can't be combined with 'enabled-checks'; default is empty @@ -83,9 +82,6 @@ linters-settings: sizeThreshold: 512 # whether to check test functions (default true) skipTestFuncs: true - truncateCmp: - # whether to skip int/uint/uintptr types (default true) - skipArchDependent: true underef: # whether to skip (*x).method() calls where x is a pointer receiver (default true) skipRecvDeref: true @@ -118,19 +114,16 @@ issues: linters: - gosec - unused - - deadcode - gocritic - path: hack\.go linters: - gosec - unused - - deadcode - gocritic - path: cmd/devp2p linters: - gosec - unused - - deadcode - gocritic - path: metrics/sample\.go linters: