Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecked calls to getField(), getSubField(), etc. #14

Open
mdavidsaver opened this issue Nov 21, 2017 · 1 comment
Open

Unchecked calls to getField(), getSubField(), etc. #14

mdavidsaver opened this issue Nov 21, 2017 · 1 comment
Assignees

Comments

@mdavidsaver
Copy link
Member

This module needs to be audited for unchecked calls to methods which can return NULL. This is especially problematic in the isCompatible() methods which are intended to be used on suspect type definitions.

StructureArrayConstPtr attributeField = structure->getField<StructureArray>( "attribute");

cf. areaDetector/ADCore#296

@mdavidsaver
Copy link
Member Author

The specific issue with NTNDArray is fixed by 91c5136. I'm going to leave this issue open pending a audit for similar issues.

@mdavidsaver mdavidsaver self-assigned this Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant