Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data in description field #30

Open
Xenomes opened this issue May 10, 2020 · 7 comments
Open

Data in description field #30

Xenomes opened this issue May 10, 2020 · 7 comments

Comments

@Xenomes
Copy link

Xenomes commented May 10, 2020

After the last update, the description field is filled with IP: mqtt info. But the already existing info is overwritten. Can you update the code to add a IP: line and update the IP: line if there is a change?
Greetings Xenomes

@emontnemery
Copy link
Owner

Please explain the problem a bit more:

Did the problem start after domoticz update or after plugin update?
Can you attach a screenshot illustrating the problem?

@Xenomes
Copy link
Author

Xenomes commented May 10, 2020

The problem started after the last update of the plugin.
image
Any values already existed in this field are replaced.

@emontnemery
Copy link
Owner

OK, that is on purpose.
The idea is to make it easier to find IP address and topic of an autodiscovered Tasmota.

If you want, an option can be added to disable updating the "Description"?

@Xenomes
Copy link
Author

Xenomes commented May 10, 2020

The idea is good, only if the description already is in use, then the other plugins won´t work. If possible add your line to the existing lines in description field.

for example:

<voicecontrol>
nicknames = Alle lichten
room = Huiskamer
report_state = True
</voicecontrol>  
IP: 192.168.1.241, Topic: sonoff_AFA1F6/cmnd

@Xenomes Xenomes changed the title Data in comment field Data in description field May 10, 2020
@emontnemery
Copy link
Owner

Aha, this makes sense.
Does the voicecontrol plugin accept additional data like in your example?

@rrozema
Copy link

rrozema commented May 15, 2020

XML content is likely not to accept any competing plugin/scripts content in the description field. Json however is more likely to accept competitors' content. Plus json content is very easily used and updated in any plugin or script. So I suggest to use json in the description field and ignore (leave untouched) any content that isn't yours. If you use some prefix specific to your script the chances of having a conflict with another plugin/script is even smaller.

@Xenomes
Copy link
Author

Xenomes commented May 15, 2020

Aha, this makes sense.
Does the voicecontrol plugin accept additional data like in your example?

I don't know, the lines get overwritten every few minutes.
Update:
i did some testing DZGA (voicecontrol) can still read the codes if i add the code of de discover MQTT plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants