Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rate limiting capabilities for api calls #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add rate limiting capabilities for api calls #19

wants to merge 2 commits into from

Conversation

sarslanhan
Copy link

No description provided.

@sarslanhan
Add editorconfig configuration
9e13667
@sarslanhan
Use timequeue package for rate limiting
08b69ef 
Since each api call on embedly has its own rate limit, they are defined
using an `Object` rather than a single `Number`.
@sarslanhan
Copy link
Author

I think there are 2 things still to be addressed here:

  • How to test these rate limits
  • Support for checking rate limits in a distributed environment.

Maybe the second one can be achieved by using something like Redis for storing limits instead of timequeue package which requires some implementation.

I would love to hear your suggestions on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sarslanhan