[Backport 8.x] Use Python types to declare document fields #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* basic type annotation support * support for optional, list, and other type hints * additional typing support * dataclass-like behavior for Document and InnerDoc * unit tests * support InstrumentedField in Search class * documentation * Update docs/persistence.rst Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> * Update elasticsearch_dsl/document_base.py Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> * addressed review feedback * better docs for Optional * fix optional in test --------- Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> (cherry picked from commit 0c3ffcd)
miguelgrinberg
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0c3ffcd from #1845.