Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #34

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 29, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for further information.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 9, 2024 12:43
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@1c8ea2f). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage          ?   73.77%           
=========================================
  Files             ?        1           
  Lines             ?       61           
  Branches          ?       25           
=========================================
  Hits              ?       45           
  Misses            ?       15           
  Partials          ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as draft August 21, 2024 08:44
@BilalQamar95 BilalQamar95 self-assigned this Aug 26, 2024
@BilalQamar95 BilalQamar95 changed the title feat: updated node to v20 build: Upgrade to Node 20 Aug 26, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Aug 26, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review September 5, 2024 08:39
@BilalQamar95 BilalQamar95 merged commit 38afad2 into master Sep 6, 2024
5 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/node-v20-upgrade branch September 6, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants