Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make global notify of onremove on a system an error #221

Open
Kelwan opened this issue May 16, 2024 · 0 comments
Open

Make global notify of onremove on a system an error #221

Kelwan opened this issue May 16, 2024 · 0 comments

Comments

@Kelwan
Copy link
Contributor

Kelwan commented May 16, 2024

Having an onremove notify that applies to the whole system doesn't really make sense (as it will have no components to filter with). A system using onremove needs to have at least 1 component without, or an error will throw.

BAD:

system RemoveNotify {
	readwrite NotifyComponentA;
	readonly NotifyComponentB;
	readonly NotifyComponentC;
	notify onremove;
}

GOOD:

system RemoveNotify {
	readwrite NotifyComponentA;
	readonly NotifyComponentC;
	notify {
		onremove NotifyComponentB;
	}
}
@Kelwan Kelwan changed the title Make global notify of onremove an error Make global notify of onremove on a system an error May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant