From ec8585e575e462a3b22be701cae8643ef32552e5 Mon Sep 17 00:00:00 2001 From: "Owen Corrigan (BJSS, VTM)" <122352145+owen-corrigan-bjss@users.noreply.github.com> Date: Fri, 26 Jan 2024 09:08:58 +0000 Subject: [PATCH] minor(cb2-10521): change adr brake endurance weight unit of measurement to tonnes on a technical record (#162) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- json-definitions/v3/tech-record/get/hgv/complete/index.json | 4 ++-- json-definitions/v3/tech-record/get/hgv/skeleton/index.json | 4 ++-- json-definitions/v3/tech-record/get/hgv/testable/index.json | 4 ++-- json-definitions/v3/tech-record/get/lgv/complete/index.json | 4 ++-- json-definitions/v3/tech-record/get/lgv/skeleton/index.json | 4 ++-- json-definitions/v3/tech-record/get/trl/complete/index.json | 4 ++-- json-definitions/v3/tech-record/get/trl/skeleton/index.json | 4 ++-- json-definitions/v3/tech-record/get/trl/testable/index.json | 4 ++-- json-schemas/v3/tech-record/get/hgv/complete/index.json | 4 ++-- json-schemas/v3/tech-record/get/hgv/skeleton/index.json | 4 ++-- json-schemas/v3/tech-record/get/hgv/testable/index.json | 4 ++-- json-schemas/v3/tech-record/get/lgv/complete/index.json | 4 ++-- json-schemas/v3/tech-record/get/lgv/skeleton/index.json | 4 ++-- json-schemas/v3/tech-record/get/trl/complete/index.json | 4 ++-- json-schemas/v3/tech-record/get/trl/skeleton/index.json | 4 ++-- json-schemas/v3/tech-record/get/trl/testable/index.json | 4 ++-- package-lock.json | 4 ++-- package.json | 2 +- tests/hgv/skeleton.test.ts | 2 +- types/v3/tech-record/get/hgv/complete/index.d.ts | 2 +- types/v3/tech-record/get/hgv/skeleton/index.d.ts | 2 +- types/v3/tech-record/get/hgv/testable/index.d.ts | 2 +- types/v3/tech-record/get/lgv/complete/index.d.ts | 2 +- types/v3/tech-record/get/lgv/skeleton/index.d.ts | 2 +- types/v3/tech-record/get/trl/complete/index.d.ts | 2 +- types/v3/tech-record/get/trl/skeleton/index.d.ts | 2 +- types/v3/tech-record/get/trl/testable/index.d.ts | 2 +- 27 files changed, 44 insertions(+), 44 deletions(-) diff --git a/json-definitions/v3/tech-record/get/hgv/complete/index.json b/json-definitions/v3/tech-record/get/hgv/complete/index.json index c2dcec85..b524bc8b 100644 --- a/json-definitions/v3/tech-record/get/hgv/complete/index.json +++ b/json-definitions/v3/tech-record/get/hgv/complete/index.json @@ -236,10 +236,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-definitions/v3/tech-record/get/hgv/skeleton/index.json b/json-definitions/v3/tech-record/get/hgv/skeleton/index.json index 8923c126..f977e2f5 100644 --- a/json-definitions/v3/tech-record/get/hgv/skeleton/index.json +++ b/json-definitions/v3/tech-record/get/hgv/skeleton/index.json @@ -206,10 +206,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-definitions/v3/tech-record/get/hgv/testable/index.json b/json-definitions/v3/tech-record/get/hgv/testable/index.json index 429beef7..21332c1a 100644 --- a/json-definitions/v3/tech-record/get/hgv/testable/index.json +++ b/json-definitions/v3/tech-record/get/hgv/testable/index.json @@ -210,10 +210,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-definitions/v3/tech-record/get/lgv/complete/index.json b/json-definitions/v3/tech-record/get/lgv/complete/index.json index d91d0a81..cbe84e0c 100644 --- a/json-definitions/v3/tech-record/get/lgv/complete/index.json +++ b/json-definitions/v3/tech-record/get/lgv/complete/index.json @@ -241,10 +241,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-definitions/v3/tech-record/get/lgv/skeleton/index.json b/json-definitions/v3/tech-record/get/lgv/skeleton/index.json index f6dc7b69..1e658cfc 100644 --- a/json-definitions/v3/tech-record/get/lgv/skeleton/index.json +++ b/json-definitions/v3/tech-record/get/lgv/skeleton/index.json @@ -238,10 +238,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-definitions/v3/tech-record/get/trl/complete/index.json b/json-definitions/v3/tech-record/get/trl/complete/index.json index f89528a9..d126fa97 100644 --- a/json-definitions/v3/tech-record/get/trl/complete/index.json +++ b/json-definitions/v3/tech-record/get/trl/complete/index.json @@ -218,10 +218,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-definitions/v3/tech-record/get/trl/skeleton/index.json b/json-definitions/v3/tech-record/get/trl/skeleton/index.json index 9c777317..b673a209 100644 --- a/json-definitions/v3/tech-record/get/trl/skeleton/index.json +++ b/json-definitions/v3/tech-record/get/trl/skeleton/index.json @@ -198,10 +198,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-definitions/v3/tech-record/get/trl/testable/index.json b/json-definitions/v3/tech-record/get/trl/testable/index.json index 868a8827..f256d588 100644 --- a/json-definitions/v3/tech-record/get/trl/testable/index.json +++ b/json-definitions/v3/tech-record/get/trl/testable/index.json @@ -200,10 +200,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-schemas/v3/tech-record/get/hgv/complete/index.json b/json-schemas/v3/tech-record/get/hgv/complete/index.json index 070dc6ec..74205706 100644 --- a/json-schemas/v3/tech-record/get/hgv/complete/index.json +++ b/json-schemas/v3/tech-record/get/hgv/complete/index.json @@ -245,10 +245,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-schemas/v3/tech-record/get/hgv/skeleton/index.json b/json-schemas/v3/tech-record/get/hgv/skeleton/index.json index 3deec883..aaffc1da 100644 --- a/json-schemas/v3/tech-record/get/hgv/skeleton/index.json +++ b/json-schemas/v3/tech-record/get/hgv/skeleton/index.json @@ -215,10 +215,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-schemas/v3/tech-record/get/hgv/testable/index.json b/json-schemas/v3/tech-record/get/hgv/testable/index.json index 4d5bd316..1b0c7c35 100644 --- a/json-schemas/v3/tech-record/get/hgv/testable/index.json +++ b/json-schemas/v3/tech-record/get/hgv/testable/index.json @@ -219,10 +219,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-schemas/v3/tech-record/get/lgv/complete/index.json b/json-schemas/v3/tech-record/get/lgv/complete/index.json index 70e71752..54fcba78 100644 --- a/json-schemas/v3/tech-record/get/lgv/complete/index.json +++ b/json-schemas/v3/tech-record/get/lgv/complete/index.json @@ -250,10 +250,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-schemas/v3/tech-record/get/lgv/skeleton/index.json b/json-schemas/v3/tech-record/get/lgv/skeleton/index.json index 506fd0cb..6e993554 100644 --- a/json-schemas/v3/tech-record/get/lgv/skeleton/index.json +++ b/json-schemas/v3/tech-record/get/lgv/skeleton/index.json @@ -247,10 +247,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-schemas/v3/tech-record/get/trl/complete/index.json b/json-schemas/v3/tech-record/get/trl/complete/index.json index 1ae6f5b5..da26f891 100644 --- a/json-schemas/v3/tech-record/get/trl/complete/index.json +++ b/json-schemas/v3/tech-record/get/trl/complete/index.json @@ -227,10 +227,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-schemas/v3/tech-record/get/trl/skeleton/index.json b/json-schemas/v3/tech-record/get/trl/skeleton/index.json index bca926ad..51effe78 100644 --- a/json-schemas/v3/tech-record/get/trl/skeleton/index.json +++ b/json-schemas/v3/tech-record/get/trl/skeleton/index.json @@ -207,10 +207,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/json-schemas/v3/tech-record/get/trl/testable/index.json b/json-schemas/v3/tech-record/get/trl/testable/index.json index 6c33bda0..4800b338 100644 --- a/json-schemas/v3/tech-record/get/trl/testable/index.json +++ b/json-schemas/v3/tech-record/get/trl/testable/index.json @@ -209,10 +209,10 @@ }, "techRecord_adrDetails_weight": { "type": [ - "string", + "number", "null" ], - "maxLength": 8 + "maximum": 99999999 }, "techRecord_adrDetails_declarationsSeen": { "type": [ diff --git a/package-lock.json b/package-lock.json index c61edd62..f08c5085 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@dvsa/cvs-type-definitions", - "version": "5.0.0", + "version": "5.1.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@dvsa/cvs-type-definitions", - "version": "5.0.0", + "version": "5.1.0", "license": "ISC", "dependencies": { "ajv": "^8.12.0", diff --git a/package.json b/package.json index 475620b1..dacbeaf1 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@dvsa/cvs-type-definitions", - "version": "5.0.0", + "version": "5.1.0", "description": "type definitions for cvs vta and vtm applications", "main": "index.js", "repository": { diff --git a/tests/hgv/skeleton.test.ts b/tests/hgv/skeleton.test.ts index 2cb29366..1f8542d1 100644 --- a/tests/hgv/skeleton.test.ts +++ b/tests/hgv/skeleton.test.ts @@ -96,7 +96,7 @@ describe("validate ADR hgv schema", () => { it("should pass if techRecord_adrDetails_brakeEndurance is true and weight is present", () => { const data = hgvData[7]; (data as any).techRecord_adrDetails_brakeEndurance = true; - (data as any).techRecord_adrDetails_weight = "123"; + (data as any).techRecord_adrDetails_weight = 123; const res = isValidObject(schemaName, data); expect(res).toEqual(true); }); diff --git a/types/v3/tech-record/get/hgv/complete/index.d.ts b/types/v3/tech-record/get/hgv/complete/index.d.ts index 9b0dd9db..e3c4add7 100644 --- a/types/v3/tech-record/get/hgv/complete/index.d.ts +++ b/types/v3/tech-record/get/hgv/complete/index.d.ts @@ -105,7 +105,7 @@ export interface TechRecordGETHGVComplete { techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null; techRecord_adrDetails_brakeDeclarationIssuer?: string | null; techRecord_adrDetails_brakeEndurance?: boolean | null; - techRecord_adrDetails_weight?: string | null; + techRecord_adrDetails_weight?: number | null; techRecord_adrDetails_declarationsSeen?: boolean | null; techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null; techRecord_adrDetails_additionalNotes_number?: string[] | null; diff --git a/types/v3/tech-record/get/hgv/skeleton/index.d.ts b/types/v3/tech-record/get/hgv/skeleton/index.d.ts index 268bd86f..6347a5a5 100644 --- a/types/v3/tech-record/get/hgv/skeleton/index.d.ts +++ b/types/v3/tech-record/get/hgv/skeleton/index.d.ts @@ -105,7 +105,7 @@ export interface TechRecordGETHGVSkeleton { techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null; techRecord_adrDetails_brakeDeclarationIssuer?: string | null; techRecord_adrDetails_brakeEndurance?: boolean | null; - techRecord_adrDetails_weight?: string | null; + techRecord_adrDetails_weight?: number | null; techRecord_adrDetails_declarationsSeen?: boolean | null; techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null; techRecord_adrDetails_additionalNotes_number?: string[] | null; diff --git a/types/v3/tech-record/get/hgv/testable/index.d.ts b/types/v3/tech-record/get/hgv/testable/index.d.ts index 3dead56d..e0ec0837 100644 --- a/types/v3/tech-record/get/hgv/testable/index.d.ts +++ b/types/v3/tech-record/get/hgv/testable/index.d.ts @@ -105,7 +105,7 @@ export interface TechRecordGETHGVTestable { techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null; techRecord_adrDetails_brakeDeclarationIssuer?: string | null; techRecord_adrDetails_brakeEndurance?: boolean | null; - techRecord_adrDetails_weight?: string | null; + techRecord_adrDetails_weight?: number | null; techRecord_adrDetails_declarationsSeen?: boolean | null; techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null; techRecord_adrDetails_additionalNotes_number?: string[] | null; diff --git a/types/v3/tech-record/get/lgv/complete/index.d.ts b/types/v3/tech-record/get/lgv/complete/index.d.ts index 0f36224b..594ce332 100644 --- a/types/v3/tech-record/get/lgv/complete/index.d.ts +++ b/types/v3/tech-record/get/lgv/complete/index.d.ts @@ -36,7 +36,7 @@ export interface TechRecordGETLGVComplete { techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null; techRecord_adrDetails_brakeDeclarationIssuer?: string | null; techRecord_adrDetails_brakeEndurance?: boolean | null; - techRecord_adrDetails_weight?: string | null; + techRecord_adrDetails_weight?: number | null; techRecord_adrDetails_declarationsSeen?: boolean | null; techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null; techRecord_adrDetails_additionalNotes_number?: string[] | null; diff --git a/types/v3/tech-record/get/lgv/skeleton/index.d.ts b/types/v3/tech-record/get/lgv/skeleton/index.d.ts index 01f15a9e..77006bf4 100644 --- a/types/v3/tech-record/get/lgv/skeleton/index.d.ts +++ b/types/v3/tech-record/get/lgv/skeleton/index.d.ts @@ -36,7 +36,7 @@ export interface TechRecordGETLGVSkeleton { techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null; techRecord_adrDetails_brakeDeclarationIssuer?: string | null; techRecord_adrDetails_brakeEndurance?: boolean | null; - techRecord_adrDetails_weight?: string | null; + techRecord_adrDetails_weight?: number | null; techRecord_adrDetails_declarationsSeen?: boolean | null; techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null; techRecord_adrDetails_additionalNotes_number?: string[] | null; diff --git a/types/v3/tech-record/get/trl/complete/index.d.ts b/types/v3/tech-record/get/trl/complete/index.d.ts index dd762797..d9552078 100644 --- a/types/v3/tech-record/get/trl/complete/index.d.ts +++ b/types/v3/tech-record/get/trl/complete/index.d.ts @@ -122,7 +122,7 @@ export interface TechRecordGETTRLComplete { techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null; techRecord_adrDetails_brakeDeclarationIssuer?: string | null; techRecord_adrDetails_brakeEndurance?: boolean | null; - techRecord_adrDetails_weight?: string | null; + techRecord_adrDetails_weight?: number | null; techRecord_adrDetails_declarationsSeen?: boolean | null; techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null; techRecord_adrDetails_additionalNotes_number?: string[] | null; diff --git a/types/v3/tech-record/get/trl/skeleton/index.d.ts b/types/v3/tech-record/get/trl/skeleton/index.d.ts index 51feb2b4..95efda54 100644 --- a/types/v3/tech-record/get/trl/skeleton/index.d.ts +++ b/types/v3/tech-record/get/trl/skeleton/index.d.ts @@ -122,7 +122,7 @@ export interface TechRecordGETTRLSkeleton { techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null; techRecord_adrDetails_brakeDeclarationIssuer?: string | null; techRecord_adrDetails_brakeEndurance?: boolean | null; - techRecord_adrDetails_weight?: string | null; + techRecord_adrDetails_weight?: number | null; techRecord_adrDetails_declarationsSeen?: boolean | null; techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null; techRecord_adrDetails_additionalNotes_number?: string[] | null; diff --git a/types/v3/tech-record/get/trl/testable/index.d.ts b/types/v3/tech-record/get/trl/testable/index.d.ts index a172473e..65d8a82d 100644 --- a/types/v3/tech-record/get/trl/testable/index.d.ts +++ b/types/v3/tech-record/get/trl/testable/index.d.ts @@ -122,7 +122,7 @@ export interface TechRecordGETTRLTestable { techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null; techRecord_adrDetails_brakeDeclarationIssuer?: string | null; techRecord_adrDetails_brakeEndurance?: boolean | null; - techRecord_adrDetails_weight?: string | null; + techRecord_adrDetails_weight?: number | null; techRecord_adrDetails_declarationsSeen?: boolean | null; techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null; techRecord_adrDetails_additionalNotes_number?: string[] | null;