Add mime types to PartExtensionProvider #1498

mikeebowen · 2023-07-26T22:16:28Z

Fixes #1488 for v3.0.0

github-actions · 2023-07-26T22:28:58Z

Test Results

    108 files     108 suites 1h 18m 18s ⏱️
  2 011 tests   2 008 ✔️   3 💤 0 ❌
48 006 runs 47 952 ✔️ 54 💤 0 ❌

Results for commit bc07bce.

♻️ This comment has been updated with latest results.

src/DocumentFormat.OpenXml.Framework/Packaging/PartExtensionProvider.cs

…the methods they are overriding

…tests

mikeebowen added 7 commits July 25, 2023 12:27

make property nullable

b876af2

add dictionary to find extensions by mime type

800e916

Merge branch 'dotnet:main' into v3.0.0-issue1488

21c7697

add test for AddImagePart with mime type

4b661c1

add additional mime types

68f9c43

remove unused usings and add rights message to top of file

3fa88ce

move mime type to extension mapping to PartExtensionProvider

8146bf0

mikeebowen requested review from twsouthwick and tomjebo July 26, 2023 22:31

twsouthwick reviewed Jul 26, 2023

View reviewed changes

src/DocumentFormat.OpenXml.Framework/Packaging/PartExtensionProvider.cs Show resolved Hide resolved

mikeebowen added 2 commits July 26, 2023 16:00

move mime type mapping to separate method

5544f27

fix override methods for AddNewPart, so that id is nullable to match …

dfa8879

…the methods they are overriding

mikeebowen requested a review from twsouthwick July 27, 2023 17:13

make id default to null, so method works with only mime type and add …

bc07bce

…tests

twsouthwick approved these changes Jul 27, 2023

View reviewed changes

mikeebowen merged commit 8710695 into dotnet:main Jul 28, 2023
27 checks passed

mikeebowen deleted the v3.0.0-issue1488 branch July 28, 2023 16:24