Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen vs Cholesky decomposition #11

Open
mariodosreis opened this issue Mar 30, 2023 · 0 comments
Open

Eigen vs Cholesky decomposition #11

mariodosreis opened this issue Mar 30, 2023 · 0 comments

Comments

@mariodosreis
Copy link
Member

There seems to be some inconsistent between how the Eigen and Cholesky decompositions of correlation matrices are implement. Results are correct, but the method used is weird. Need to check the write.morpho and other functions that use the decomposition, and standardise. Perhaps we should just keep the Eigen decomposition. For example, for post hoc ancestral sequence reconstruction, it is important to use the same decomposition used when writing the morphological alignment, otherwise the reconstruction may be wrong (need to check this). Using a single method for the decomposition would avoid this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant