Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate member-added messages with securejoin #5992

Open
hpk42 opened this issue Sep 24, 2024 · 1 comment
Open

De-duplicate member-added messages with securejoin #5992

hpk42 opened this issue Sep 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@hpk42
Copy link
Contributor

hpk42 commented Sep 24, 2024

with securejoin it's irritating and noisy for users to see system messages about "X added Y" multiple times if "X" has a multi-device setup and posted an invite link somewhere. We can not easily co-ordinate on the "adding side" but we should be able to de-duplicate/skip the "member added" system message maybe just on the condition that the user is already a member.

@hpk42 hpk42 added the enhancement New feature or request label Sep 24, 2024
@iequidoo
Copy link
Collaborator

The "Message-ID" solution from #5356 should also solve the problem and works even if Y is removed before another vg-member-added is received. Otoh the @hpk42's solution works for members joined between vg-member-added messages which can easily happen if multiple members are added at the same time, so maybe implementing it first makes more sense, and it should be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants