Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_import_export_online_all failed because of the import progress jumping over 249 #5804

Open
iequidoo opened this issue Jul 28, 2024 · 0 comments

Comments

@iequidoo
Copy link
Collaborator

https://github.com/deltachat/deltachat-core-rust/actions/runs/10132963150/job/28017593275

        lp.sec("import backup and check it's proper")
        with ac2.temp_plugin(ImexTracker()) as imex_tracker:
            ac2.import_all(path)
    
            # check progress events for import
>           assert imex_tracker.wait_progress(1, progress_upper_limit=249)

tests/test_1_online.py:1564: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <deltachat.tracker.ImexTracker object at 0x7fe8e00d8490>
target_progress = 1, progress_upper_limit = 249, progress_timeout = 60

    def wait_progress(self, target_progress, progress_upper_limit=1000, progress_timeout=60):
        while True:
            ev = self._imex_events.get(timeout=progress_timeout)
            if isinstance(ev, int) and ev >= target_progress:
>               assert ev <= progress_upper_limit, (
                    str(ev) + " exceeded upper progress limit " + str(progress_upper_limit)
                )
E               AssertionError: 661 exceeded upper progress limit 249
E               assert 661 <= 249

I haven't yet understood how this is possible because we always report progress=10 here:

context.emit_event(EventType::ImexProgress(10));
. Probably this is related to the recent changes to the backup export/import, but it seems that the bug is in the test e.g. it misses the corresponding event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant