[stable/aws-s3-proxy] Sync labels btw pod and deployment #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueHorn07
changed the title
max-rocket-internet
requested changes
Jul 1, 2024
| @@ -8,13 +8,11 @@ spec: | |||
| replicas: {{ .Values.replicaCount }} | |||
| selector: | |||
| matchLabels: | |||
| app.kubernetes.io/name: {{ include "aws-s3-proxy.name" . }} | |||
| app.kubernetes.io/instance: {{ .Release.Name }} | |||
| {{ include "aws-s3-proxy.labels" . | indent 6 }} | |||
There was a problem hiding this comment.
I don't think this part should change as selector labels are immutable and shouldn't be treated like the other labels 🙂
There was a problem hiding this comment.
Hi there, thanks for your comment!
Are you suggesting that the changes to matchLabels might cause breaking changes? If that’s the case, I’ll revert the changes to matchLabels. 🙏
There was a problem hiding this comment.
Exactly, they are immutable, you can't change them without deleting and recreating the resource. So I would just not change this part.
There was a problem hiding this comment.
I’ve reverted it. Thanks for pointing it out and for your kind review! 😄
max-rocket-internet
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The labels for Deployment, Ingress, and Services are defined as aws-s3-proxy.labels in the _helpers.tpl file. However, the labels for pods do not use these common labels.
In my experience, when I added extraLabels in the values file, they were not applied to the pods’ labels, only to the Deployment and other resources.
I believe that using the defined common labels for pods as well would be more helpful.
Checklist
[stable/mychartname])