Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-problem-detector]: Adding support for defining volumeType of localtime #509

Merged
merged 1 commit into from
Aug 29, 2023
Merged

[stable/node-problem-detector]: Adding support for defining volumeType of localtime #509

merged 1 commit into from
Aug 29, 2023

Conversation

nishant221
Copy link
Contributor

@nishant221 nishant221 commented Aug 29, 2023 •
edited
Loading

Description

The changes in this PR is to add support for defining volumeType of volume named localtime in node-problem-detector DaemonSet template. The default is set to FileOrCreate.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@nishant221 nishant221 requested a review from a team as a code owner August 29, 2023 05:17
adriananeci
adriananeci reviewed Aug 29, 2023
View reviewed changes
Copy link

@adriananeci adriananeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

max-rocket-internet
max-rocket-internet approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nishant221 💙

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) August 29, 2023 07:08
@max-rocket-internet max-rocket-internet merged commit b364eb5 into deliveryhero:master Aug 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriananeci adriananeci adriananeci left review comments

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nishant221 @max-rocket-internet @adriananeci