[stable/node-local-dns]: feat(node-local-dns): add option to override coreDNS config #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-rocket-internet
requested changes
Aug 21, 2023
stable/node-local-dns/README.md
Outdated
| @@ -12,44 +12,19 @@ Further documentation is [here](https://kubernetes.io/docs/tasks/administer-clus | |||
|
|
|||
| This helm chart works for both kube-proxy setups (iptables or ipvs). | |||
|
|
|||
| ## How to install this chart | |||
There was a problem hiding this comment.
This can't be removed 🙂
There was a problem hiding this comment.
Something must have gone wrong during the doc generation, it should look a bit better now
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This is good feature, and would benefit anyone using CustomCNI |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Can we get input if this can be implemented or not |
The CI tests are failing, fix them and it can be merged. |
3 tasks
|
Since #526 was merged, I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds possiblity to completly override generated configuration.
Checklist
[stable/mychartname])