Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-local-dns] support podlabels and ds labels, annotations #506

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[stable/node-local-dns] support podlabels and ds labels, annotations #506

merged 2 commits into from
Aug 21, 2023

Conversation

Kostavro
Copy link
Contributor

@Kostavro Kostavro commented Aug 14, 2023 •
edited
Loading

Description

Adding support for configuring custom DaemonSet Annotations and Labels and Pod Labels.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@Kostavro Kostavro requested a review from a team as a code owner August 14, 2023 18:30
max-rocket-internet
max-rocket-internet approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Kostavro 💙

@max-rocket-internet max-rocket-internet merged commit a5b8976 into deliveryhero:master Aug 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kostavro @max-rocket-internet