Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stable/node-local-dns Extend daemonset arg list #503

Merged
merged 4 commits into from
Aug 11, 2023
Merged

stable/node-local-dns Extend daemonset arg list #503

merged 4 commits into from
Aug 11, 2023

Conversation

kkonnov
Copy link
Contributor

@kkonnov kkonnov commented Aug 8, 2023

Description

Extend daemonset arg list

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@kkonnov kkonnov requested a review from a team as a code owner August 8, 2023 15:35
max-rocket-internet
max-rocket-internet reviewed Aug 9, 2023
View reviewed changes
stable/node-local-dns/values.yaml Outdated
Comment on lines 22 to 26
setupInterface: {}

setupIptables: {}

skipTeardown: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are not maps, they are simply booleans, no? e.g. -setupiptables=false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are boolean. Changed. Can you check please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @max-rocket-internet. Any news?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README hasn't been updated with the new boolean values

max-rocket-internet
max-rocket-internet reviewed Aug 11, 2023
View reviewed changes
stable/node-local-dns/templates/daemonset.yaml Outdated
- "{{ include "node-local-dns.fullname" . }}-upstream"
- -skipteardown={{ .Values.config.skipTeardown }}
- -setupinterface={{ .Values.config.setupInterface }}
- -setupiptables={{ .Values.config.setupIptables }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is change you are re-ordering all the args and it looks like the order matters, no?

Before: -localip 169.254.20.25,172.20.0.10 -conf /etc/Corefile -upstreamsvc node-local-dns-upstream

After: -localip -conf /etc/Corefile -upstreamsvc 169.254.20.25,172.20.0.10 node-local-dns-upstream...

@kkonnov
Copy link
Contributor Author

kkonnov commented Aug 11, 2023

yeah, my bad.
In that case, I suggest this structure:

  • more readable
  • possibility to redefine
  • independent of the order of variables

Please take a look

max-rocket-internet
max-rocket-internet approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, nice, thanks @kkonnov

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) August 11, 2023 13:28
@max-rocket-internet max-rocket-internet merged commit 57cf1b0 into deliveryhero:master Aug 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkonnov @max-rocket-internet