Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/node-local-dns] feat: Add option to set securityContext #493

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

zzorica
Copy link
Contributor

@zzorica zzorica commented Jul 5, 2023

Node-local-dns doesn't need to run in privileged mode and NET_ADMIN cap is enough. But just in case I am missing something this would set it as an option and leave privileged mode as "default".

To run in non-privileged mode in values this will do it:

securityContext:
  capabilities:
    add:
    - NET_ADMIN

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@zzorica zzorica requested a review from a team as a code owner July 5, 2023 19:35
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK cool, thanks @zzorica

@max-rocket-internet max-rocket-internet merged commit 1dcf170 into deliveryhero:master Jul 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants