change structure

deliveryhero · Aug 11, 2023 · a39b00d · a39b00d
1 parent e5b8afa
commit a39b00d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 21 deletions.
diff --git a/stable/node-local-dns/README.md b/stable/node-local-dns/README.md
@@ -50,17 +50,13 @@ helm install my-release deliveryhero/node-local-dns -f values.yaml
 |-----|------|---------|-------------|
 | affinity | object | `{}` |  |
 | config.commProtocol | string | `"force_tcp"` |  |
-| config.configArgs[0] | string | `"-localip"` |  |
-| config.configArgs[1] | string | `"-conf"` |  |
-| config.configArgs[2] | string | `"/etc/Corefile"` |  |
-| config.configArgs[3] | string | `"-upstreamsvc"` |  |
 | config.dnsDomain | string | `"cluster.local"` |  |
 | config.dnsServer | string | `"172.20.0.10"` |  |
 | config.healthPort | int | `8080` |  |
 | config.localDns | string | `"169.254.20.25"` |  |
-| config.setupInterface | object | `{}` |  |
-| config.setupIptables | object | `{}` |  |
-| config.skipTeardown | object | `{}` |  |
+| config.setupInterface | bool | `false` |  |
+| config.setupIptables | bool | `false` |  |
+| config.skipTeardown | bool | `true` |  |
 | dashboard.annotations | object | `{}` |  |
 | dashboard.enabled | bool | `false` |  |
 | dashboard.label | string | `"grafana_dashboard"` |  |

diff --git a/stable/node-local-dns/templates/daemonset.yaml b/stable/node-local-dns/templates/daemonset.yaml
@@ -51,14 +51,15 @@ spec:
         resources: {{- toYaml . | nindent 10 }}
         {{- end }}
         args:
-        {{- range .Values.configArgs }}
-        - {{ . }}
-        {{- end }}
-        - "{{ .Values.config.localDns }},{{ .Values.config.dnsServer }}"
-        - "{{ include "node-local-dns.fullname" . }}-upstream"
-        - -skipteardown={{ .Values.config.skipTeardown }}
-        - -setupinterface={{ .Values.config.setupInterface }}
-        - -setupiptables={{ .Values.config.setupIptables }}
+          - "-localip"
+          - "{{ .Values.config.localDns }},{{ .Values.config.dnsServer }}"
+          - "-conf"
+          - "/etc/Corefile"
+          - "-upstreamsvc"
+          - "{{ include "node-local-dns.fullname" . }}-upstream"
+          - "-skipteardown={{ .Values.config.skipTeardown }}"
+          - "-setupinterface={{ .Values.config.setupInterface }}"
+          - "-setupiptables={{ .Values.config.setupIptables }}"
         securityContext:
           {{- toYaml .Values.securityContext | nindent 10 }}
         ports:

diff --git a/stable/node-local-dns/values.yaml b/stable/node-local-dns/values.yaml
@@ -25,12 +25,6 @@ config:
 
   skipTeardown: true
 
-  configArgs:
-    - "-localip"
-    - "-conf"
-    - "/etc/Corefile"
-    - "-upstreamsvc"
-
 nameOverride: ""
 fullnameOverride: ""