Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd service misses EXTRA options #13

Open
hvisage opened this issue Oct 7, 2015 · 4 comments
Open

systemd service misses EXTRA options #13

hvisage opened this issue Oct 7, 2015 · 4 comments

Comments

@hvisage
Copy link

hvisage commented Oct 7, 2015

Need to replace templates/etc/systemd/system/tinc@.service.j2 line 9:
ExecStart=/usr/sbin/tincd -D -n %i -o Interface=%i --mlock --chroot --user={{ tinc_user }}

with the following:
ExecStart=/usr/sbin/tincd -D {{ tinc_extra_options }} -n %i -o Interface=%i --mlock --chroot --user={{ tinc_user }}

@drybjed
Copy link
Member

drybjed commented Oct 7, 2015

If /etc/default/tinc is set up on systemd hosts, I would go straight instead and add EnvironmentFie= entry and the specific variable instead of putting the configuration in the unit file directly by Ansible. This helps by keeping the configuration in one place and leaving the unit files static, which means that systemd doesn't need to be reloaded each time configuration changes.

@hvisage
Copy link
Author

hvisage commented Oct 7, 2015

Even better :)
/me aren't a systemd fanatic

@hvisage
Copy link
Author

hvisage commented Oct 7, 2015

Perhaps also move the --chroot to that file?

@ypid
Copy link
Member

ypid commented Aug 27, 2016

@hvisage This issue should be solved as of debops.tinc v0.2.1. Can you close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants