Server consolidation #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
force-pushed
the
dev/paul/9031-server-function-outlining
branch
from
f6256e9
to
c62d684
Compare
eccles
force-pushed
the
dev/paul/9031-server-function-outlining
branch
from
c62d684
to
788a3cf
Compare
eccles
force-pushed
the
dev/paul/9031-server-function-outlining
branch
2 times, most recently
from
44dbaa4
to
b1acef2
Compare
Stuttering removed - GRPCServer renamed to just Server and similarly for http and restproxyserver. grpcserver now accepts 'port' as an argument instead of getting the value from the environment. metricsServer creation is now a single method AB#9031
eccles
force-pushed
the
dev/paul/9031-server-function-outlining
branch
from
b1acef2
to
d2c9851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuttering removed - GRPCServer renamed to just Server and similarly for http and restproxyserver.
grpcserver now accepts 'port' as an argument instead of getting the value from the environment.
AB#9031