working up an email to call for adoption #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinbryce
commented
Sep 11, 2024
added 2 commits
September 12, 2024 18:33
SteveLasker
reviewed
Sep 12, 2024
Comment on lines
+42
to
+43
| While regular checkpoints and consistency proofs can be requested for any Merkle-based log, being able to instantly replicate the VDS data puts the verifier in control of the frequency and granularity of verification. | ||
| Since each replicated (and attested) log is as reliable as the original, this can also significantly improve scalability. |
There was a problem hiding this comment.
I believe you're talking about the MMR comparison, which wasn't as obvious. Suggest you include "MMR", to remove ambiguity of which "this" or assumption of which you're referring to
Suggested change
| While regular checkpoints and consistency proofs can be requested for any Merkle-based log, being able to instantly replicate the VDS data puts the verifier in control of the frequency and granularity of verification. | |
| Since each replicated (and attested) log is as reliable as the original, this can also significantly improve scalability. | |
| Since each replicated (and attested) MMR log is as reliable as the original, <this> can also significantly improve scalability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wont ever merge this, but I figure its a great way to get input from people before I send to the cose group.
Its understood that the email is a personal contribution, but help and advice appreciated!