From 045df339b40dc1346036a4b24313b12378db756e Mon Sep 17 00:00:00 2001
From: Damien S <55164385+damiensellier@users.noreply.github.com>
Date: Fri, 10 May 2024 20:16:37 -0400
Subject: [PATCH] CtrlrSysexProcessor.cpp reverted to 5.6.30

CtrlrSysexProcessor.cpp reverted to 5.6.30
Roland Checksum calculator was crashing

Co-Authored-By: John Goodland <76831683+dnaldoog@users.noreply.github.com>
---
 Source/Core/CtrlrSysexProcessor.cpp | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/Source/Core/CtrlrSysexProcessor.cpp b/Source/Core/CtrlrSysexProcessor.cpp
index 49165c34..e7d05f9d 100755
--- a/Source/Core/CtrlrSysexProcessor.cpp
+++ b/Source/Core/CtrlrSysexProcessor.cpp
@@ -377,23 +377,16 @@ void CtrlrSysexProcessor::checksumRolandJp8080(const CtrlrSysexToken token, Midi
 	*/
 
 	const int startByte = token.getPosition() - token.getAdditionalData();
-	//double chTotal		= 0.0;
-    int checkSum = 0;
+	double chTotal		= 0.0;
 	uint8 *ptr	= (uint8 *)m.getRawData();
 
 	for (int i=startByte; i<token.getPosition(); i++)
 	{
-		//chTotal = chTotal + *(ptr+i); // From v5.6.31
-        checkSum = checkSum + *(ptr+i);
+		chTotal = chTotal + *(ptr+i); // From v5.6.31
 	}
-    /** Added by Dnaldoog from v5.6.31 */
-    //const double remainder    = fmod(chTotal, 128);
-    //const uint8 ch            = (uint8)(remainder ? (128 - remainder) : 0);
-    //checkSum &= 0x7F; /* Clamp to 7 bits */
-    checkSum = ~checkSum;
-    ++checkSum; /* This and the above operation take the two's complement */
-    checkSum &= 0x7F; /* Clamp to 7 bits */
-    *(ptr+token.getPosition())   = checkSum;
+    const double remainder    = fmod(chTotal, 128);
+    const uint8 ch            = (uint8)(remainder ? (128 - remainder) : 0);
+    *(ptr+token.getPosition())   = ch;
 }
 
 void CtrlrSysexProcessor::checksumWaldorfRackAttack(const CtrlrSysexToken token, MidiMessage &m)