-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StorageAnalyzer slows system responsiveness after opening heavily populated media folders #1166
Comments
If you disable previews in SD Maids settings, does it perform better? |
With file previews disabled, StorageAnalyzer behaves much better in my test folder! The high file count on its own clearly isn't the problem. Do you need me to check some other behavior? Maybe I could try removing the Improvement opportunity there would be only to help the UI stay responsive while thumbs are created, since it looks like an external library called |
The
This should not be a concern as it (should) only load thumbnails for files that are visible in the list (+/- a few extra at the start and at the end). I tested this on my phone with 5k media files in the WhatsApp folder and it did only load those items that were visible. Fast scrolling even cancels loading for items no longer in view. Is this on an external sdcard and could it be possible that the sdcard is very slow and these operations hangup the whole OS because the I/O operations are piling up? |
I haven't managed to reproduce the extreme system-wide GUI lag I saw before, so let me strikeout that part of the original issue until/unless I can make it happen again.
I thought of storage speed as a possible factor. Neither device I tested before opening the issue even supports expandable storage (😡 modern Android designs), but the unresponsiveness is more noticeable on the cheaper OnePlus device. Confoundingly, though, both advertise UFS 3.1 storage in their hardware specifications—so I'm inclined to think the difference is attributable to the different SoCs instead (Dimensity 9000 vs. Snapdragon 865).
The faster device (ROG 3/SD865) is able to scroll around a 20k-file folder with no issues as you describe here, except at the beginning of the list where StorageAnalyzer sorts the several-hundred-MB video files my test folder contains. If I fast-scroll away from the huge video files down to single-digit-MB images, as soon as I can after opening the huge folder, I can spot thumbs being generated in quick sequence after some waiting. The delay suggests that thumbs are generated sequentially; and that once a large file starts being thumbnailed, the operation perhaps can't be canceled? Maybe my earlier tests actually made the issue worse by queueing additional large videos, since I was scrolling not very far down, only around the top of the list where all the biggest (and therefore likely most expensive) files are. While testing the scroll behavior, I found and replaced a couple of files that hadn't downloaded correctly and were sitting at 0 bytes. Normally I'd have no reason to look at the small end of the analyzer's report for a folder, so thanks for the excuse to play around! |
Sounds like thumbnailing the big videos is causing the slow down 🤔 I thought they are being created in parallel, but I'll have to check, I think it's just using |
Describe the bug
System becomes slow or unresponsive after StorageAnalyzer has been used to view a folder containing many (thousands) media files.
To Reproduce
Steps to reproduce the behavior:
/storage/emulated/0/Pictures/TestFolder
.nomedia
file to this folder — I am not sure yet if this influences the behaviorExpected behavior
Regardless of how many files are in a given folder, browsing StorageAnalyzer results should remain responsive.
Smartphone (please complete the following information):
Debug log
I will be happy to add this later, if needed; it takes quite a while to scan my devices
Screenshots/Video
As above, happy to add if needed.
Additional context
Generally I end up restarting the whole device to get responsiveness back. I can usually do so through the normal menus, with patience, but occasionally it has been bad enough that I considered just holding the power button to force shutdown.Edit: I have not been able to reproduce this extreme lag. Let's ignore it unless/until I can get a clear way to repro.
The text was updated successfully, but these errors were encountered: