-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json engines
lists Node.js 14 in end-of-life status
#687
Comments
The main Cypress repo cypress-io/cypress uses Yarn and in the default develop branch it specifies: "engines": {
"node": ">=16.16.0",
"yarn": ">=1.17.3"
}, so updating this repo should not cause a problem for building Cypress. cypress-io/cypress/blob/develop/cli/package.json however specifies: "engines": {
"node": "^14.0.0 || ^16.0.0 || >=18.0.0"
}, which affects the released npm package cypress so I suggest delaying changes in the cypress-io/cypress-example-kitchensink until the |
Are there any plans to update I can't see any change so far to "engines": {
"node": "^14.0.0 || ^16.0.0 || >=18.0.0"
}, |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Node.js
14
is still listed in package.json although it entered end-of-life on April 30, 2023.currently lists
as supported Node.js versions. This is no longer in line with the Node.js release schedule:
14
passed into end-of-life status on Apr 30, 202319
passed into end-of-life status on Jun 1, 202320
was released on Apr 18, 2023(in addition
16
is planned to transition into end-of-life status on Sep 11, 2023)Currently:
package-lock.json uses
"lockfileVersion": 2
which produces a warning whennpm install
is used with Node.js14
. Ifnpm ci
is used, no warning is issued regarding thelockfileVersion
..node-version already specifies Node.js
18
as the compatible version for this repository.Suggestion
To reflect the official Node.js release schedule update the
engines
section to:Yarn strictly enforces engine constraints. npm produces warnings by default if engine constraints are not met.
Changes to the engines definition need to be declared as a BREAKING CHANGE meaning that a new major version number would be created at release time.
The text was updated successfully, but these errors were encountered: