Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis spec may need tightening #6

Open
jonblower opened this issue Nov 20, 2021 · 1 comment
Open

Axis spec may need tightening #6

jonblower opened this issue Nov 20, 2021 · 1 comment

Comments

@jonblower
Copy link
Member

jonblower commented Nov 20, 2021

  • "If missing, the member "dataType" defaults to "primitive" and MUST not be included for that default case." - this is not clear to me
  • Is coordinates required for tuples and polygon axes?
  • Is bounds only valid for primitive-valued axes based on an array of values (I assume so)
@letmaik
Copy link
Member

letmaik commented Feb 4, 2022

  • "If missing, the member "dataType" defaults to "primitive" and MUST not be included for that default case." - this is not clear to me

It just means never include "dataType": "primitive". The reason for this is to enforce a canonical format. This is the same as for "timeScale" in "TemporalRS".

  • Is coordinates required for tuples and polygon axes?

It is required whenever there is more than one coordinate, and this should be spelled out. Polygons always have two, and tuples at least one. The 1-tuple degenerate case should probably be discouraged in favour of using a primitive axis.

  • Is bounds only valid for primitive-valued axes based on an array of values (I assume so)

In practice yes. I think we left it unconstrained in case there will be something non-primitive that could make use of it as well. I'm fine with tightening it up to make it clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants