From 4e8cf67cc2b942a62f967569a3c9086207be7bbc Mon Sep 17 00:00:00 2001 From: Maik Riechert Date: Wed, 22 Jun 2022 09:20:30 +0200 Subject: [PATCH] minor cleanup of grid and verticalprofile tests (#36) --- test/domain_types/test_grid.py | 19 ++----------------- test/domain_types/test_verticalprofile.py | 1 - 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/test/domain_types/test_grid.py b/test/domain_types/test_grid.py index a90ba2c..8f1e46f 100644 --- a/test/domain_types/test_grid.py +++ b/test/domain_types/test_grid.py @@ -61,29 +61,14 @@ def test_empty_t_axis(validator, grid_domain): validator.validate(grid_domain) -def test_extra_multi_coordinate_axis(validator, grid_domain): - ''' Invalid: Grid domain with unrecognised multi-coordinate axis ''' +def test_extra_coordinate_axis(validator, grid_domain): + ''' Invalid: Grid domain with unrecognised axis ''' grid_domain["axes"]["x2"] = grid_domain["axes"]["x"] with pytest.raises(ValidationError): validator.validate(grid_domain) -# TODO the schema forbids this currently, but the spec allows it -# def test_extra_single_coordinate_axis(validator, grid_domain): -# ''' Valid: Grid domain with unrecognised single-coordinate axis ''' - -# grid_domain["axes"]["x2"] = { "values": [1] } -# grid_domain["referencing"].append({ -# "coordinates": ["x2"], -# "system": { -# "type": "GeographicCRS", -# "id": "http://foo" -# } -# }) -# validator.validate(grid_domain) - - def test_wrong_x_axis_type_with_no_domain_type(validator, grid_domain): ''' Grid domain with a tuple axis instead of a primitive one, but there is no domainType so it will validate ''' diff --git a/test/domain_types/test_verticalprofile.py b/test/domain_types/test_verticalprofile.py index 7bce0f3..9cf2ef3 100644 --- a/test/domain_types/test_verticalprofile.py +++ b/test/domain_types/test_verticalprofile.py @@ -85,7 +85,6 @@ def test_multivalued_y_axis(validator, verticalprofile_domain): validator.validate(verticalprofile_domain) -# TODO: this is not explicity forbidden in the spec, but should be - see #96 def test_multivalued_t_axis(validator, verticalprofile_domain): ''' Invalid: VerticalProfile domain with multi-valued 't' axis '''