feat: add Mistral Instruct model to the catalog #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containers#1771 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
benoitf
reviewed
Sep 24, 2024
| @@ -303,6 +303,19 @@ | |||
| }, | |||
| "sha256": "893ae2442b36b2e8e1134ccbf8c0d9bd670648d0964509202ab30c9cbb3d2114", | |||
| "backend": "none" | |||
| }, | |||
| { | |||
| "id": "hf.MaziyarPanahi.Mistral-7B-Instruct-v0.3.Q4_K_M", | |||
There was a problem hiding this comment.
should it come from https://huggingface.co/mistralai rather than "hf.MaziyarPanahi"
There was a problem hiding this comment.
They don't provide GGUF files thus this repo
benoitf
approved these changes
Sep 25, 2024
gastoner
approved these changes
Sep 26, 2024
axel7083
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
LGTM
I know we had some idea at some point to include the model converter (.safetensor => gguf) inside ai lab
- Integrate Model converter for running models without GGUF file #542
- https://github.com/containers/ai-lab-recipes/tree/main/convert_models
Maybe we should re-evaluate this ?
That needs to be tested first as GGUF contains model metadata (template,...) that are not present in the safe tensor format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1771
What does this PR do?
Add a new model to the catalog
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
#1771
How to test this PR?
Test with playground