Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new observibility - Introduce Subscriber Configuration #1057

Closed
karlem opened this issue Jul 8, 2024 · 0 comments · Fixed by #1063
Closed

Introduce new observibility - Introduce Subscriber Configuration #1057

karlem opened this issue Jul 8, 2024 · 0 comments · Fixed by #1063
Assignees
@karlem

Comments

@karlem
Copy link
Contributor

karlem commented Jul 8, 2024

Description

Implement the configuration for the subscriber. Ensure dynamic reconfiguration is supported. Test the configuration thoroughly.

Tasks

  • Implement subscriber configuration.
  • Support dynamic reconfiguration.
  • Test the configuration functionality.

Acceptance Criteria

  • Subscriber configuration is implemented.
  • Dynamic reconfiguration is supported and functional.
  • Configuration is thoroughly tested.

Part of #1055
@karlem karlem self-assigned this Jul 8, 2024
@karlem karlem mentioned this issue Jul 8, 2024
Closed
@karlem karlem changed the title Implement New Observability - Introduce Subscriber Configuration Introduce new observibility - Introduce Subscriber Configuration Jul 8, 2024
@karlem karlem mentioned this issue Jul 11, 2024
Merged
karlem added a commit that referenced this issue Jul 15, 2024
@karlem
Introduce New Observability - Configuration (#1063)
b693a80 
Close #1057 

There is a problem with using the configuration file because we want to
set up tracing before the configuration is loaded. At least, this is how
it currently works. Therefore, some kind of dynamic layer will need to
be added to the subscriber layer when we want to use the configuration
file. That is why I just used environment variables for now to cut
corners and get this out as soon as possible. Once all metrics are
implemented, I can fix the configuration reloading.
@karlem karlem closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlem karlem

Labels
None yet
Projects
IPC Core Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce New Observability - Configuration consensus-shipyard/ipc
1 participant
@karlem