diff --git a/ecs_composex/common/stacks/__init__.py b/ecs_composex/common/stacks/__init__.py index 7baa33f1..2f375e6b 100644 --- a/ecs_composex/common/stacks/__init__.py +++ b/ecs_composex/common/stacks/__init__.py @@ -285,6 +285,13 @@ def set_vpc_parameters_from_vpc_stack( APP_SUBNETS, ] add_parameters(self.stack_template, default_parameters) + print( + "STACK TEMPLATE?", + self.stack_template, + type(self.stack_template), + self.stack_template.parameters, + ) + print("ADDED DEFAULT PARAMS") if ( self.parent_stack and self.parent_stack is not None diff --git a/ecs_composex/ecs/ecs_family/__init__.py b/ecs_composex/ecs/ecs_family/__init__.py index 957ac4c2..b49ed2ad 100644 --- a/ecs_composex/ecs/ecs_family/__init__.py +++ b/ecs_composex/ecs/ecs_family/__init__.py @@ -300,15 +300,20 @@ def generate_outputs(self): """ Generates a list of CFN outputs for the ECS Service and Task Definition """ - if self.service_networking.security_group: + if ( + self.service_compute.launch_type != "EXTERNAL" + and self.service_networking.security_group + ): self.outputs.append( CfnOutput( f"{self.logical_name}GroupId", Value=Ref(self.service_networking.security_group.parameter.title), ) ) - if self.service_networking.subnets_output and isinstance( - self.service_networking.subnets_output, Ref + if ( + self.service_networking.subnets_output + and isinstance(self.service_networking.subnets_output, Ref) + and self.service_compute.launch_type != "EXTERNAL" ): self.outputs.append( CfnOutput(