From e7a707d9da3ea38e2637972ce2185e8071cb2b49 Mon Sep 17 00:00:00 2001 From: hugolafis <77360365+hugolafis@users.noreply.github.com> Date: Tue, 21 May 2024 12:19:09 +0100 Subject: [PATCH] fix: document event listener potentially not unregistered (#4509) Co-authored-by: Hugo Newman Co-authored-by: Christopher J. Tannum --- viewer/packages/camera-manager/src/DefaultCameraManager.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/viewer/packages/camera-manager/src/DefaultCameraManager.ts b/viewer/packages/camera-manager/src/DefaultCameraManager.ts index e79483aa6f3..b308bb83a9b 100644 --- a/viewer/packages/camera-manager/src/DefaultCameraManager.ts +++ b/viewer/packages/camera-manager/src/DefaultCameraManager.ts @@ -350,6 +350,7 @@ export class DefaultCameraManager implements CameraManager { } this.keyboardNavigationEnabled = keyboardNavigationEnabled; this._domElement.removeEventListener('pointerdown', stopTween); + document.removeEventListener('keydown', stopTween); }) .start(TWEEN.now()); tween.update(TWEEN.now()); @@ -411,6 +412,7 @@ export class DefaultCameraManager implements CameraManager { this.setComboControlsOptions({ lookAtViewTarget: false }); this.keyboardNavigationEnabled = keyboardNavigationEnabled; this._domElement.removeEventListener('pointerdown', stopTween); + document.removeEventListener('keydown', stopTween); }) .start(TWEEN.now()); tween.update(TWEEN.now());