From b4a1ccee82505df6af56e18062aed36cae83d758 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5kon=20Flatval?= Date: Wed, 17 Jul 2024 10:03:50 +0200 Subject: [PATCH] chore: update tsdocs and API file --- viewer/packages/camera-manager/src/CameraManagerHelper.ts | 7 +++++-- viewer/reveal.api.md | 2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/viewer/packages/camera-manager/src/CameraManagerHelper.ts b/viewer/packages/camera-manager/src/CameraManagerHelper.ts index 683f825e98f..15f7fa9b84f 100644 --- a/viewer/packages/camera-manager/src/CameraManagerHelper.ts +++ b/viewer/packages/camera-manager/src/CameraManagerHelper.ts @@ -113,8 +113,6 @@ export class CameraManagerHelper { * Updates near and far plane of the camera based on the bounding box. * @param camera Used camera instance. * @param boundingBox Bounding box of all objects on the scene. - * @param nearAndFarPlaneBuffers to read from - * @param cameraFarBuffers * @deprecated use instance method instead */ static updateCameraNearAndFar(camera: PerspectiveCamera, boundingBox: Box3): void { @@ -126,6 +124,11 @@ export class CameraManagerHelper { ); } + /** + * Updates near and far plane of the camera based on the bounding box. + * @param camera Used camera instance. + * @param boundingBox Bounding box of all objects on the scene. + */ public updateCameraNearAndFar(camera: PerspectiveCamera, boundingBox: Box3): void { CameraManagerHelper.updateCameraNearAndFarInternal( camera, diff --git a/viewer/reveal.api.md b/viewer/reveal.api.md index 9f661ab9e1b..b8df6ec12bc 100644 --- a/viewer/reveal.api.md +++ b/viewer/reveal.api.md @@ -333,7 +333,9 @@ export class CameraManagerHelper { }; static calculateNewRotationFromTarget(camera: PerspectiveCamera, newTarget: Vector3): Quaternion; static calculateNewTargetFromRotation(camera: PerspectiveCamera, rotation: Quaternion, currentTarget: Vector3, position: Vector3): Vector3; + // @deprecated static updateCameraNearAndFar(camera: PerspectiveCamera, boundingBox: Box3): void; + updateCameraNearAndFar(camera: PerspectiveCamera, boundingBox: Box3): void; } // @public (undocumented)