Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rocket.Chat] Add rocketchat backend support to ELK #876

Closed
vchrombie opened this issue May 17, 2020 · 4 comments
Closed

[Rocket.Chat] Add rocketchat backend support to ELK #876

vchrombie opened this issue May 17, 2020 · 4 comments

Comments

@vchrombie
Copy link
Member

This issue in reference to the PR, chaoss/grimoirelab-perceval#661.

It is about adding rocketchat backend support to grimoirelab-elk.

@animeshk08, I want to know if you are working on this. If not, I would like to take this up this, and would you be interested to review? As you have some pretty good experience with elk already, it would be great if you can help me by reviewing the work.

@animeshk08
Copy link
Contributor

animeshk08 commented May 18, 2020

Hi, @vchrombie. Sorry, but I have already created the enricher for this backend. I just to finalize the unit tests and I will be creating a PR either today or tomorrow :)

I would love to receive your review since you are interested in this issue :)

@vchrombie
Copy link
Member Author

Hi, @vchrombie. Sorry, but I have already created the enricher for this backend. I just to finalize the unit tests and I will be creating a PR either today or tomorrow :)

No problem, you can complete the PR. You can reference this issue so that it would close after the PR is merged.

@vchrombie
Copy link
Member Author

I think this can be closed with the recent merge #890.

@valeriocos
Copy link
Member

Yes, thanks @vchrombie . Feel free to close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants