Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakiness in TestTransportMultiplexAcceptNonBlocking #1439

Open
1 task
staheri14 opened this issue Jul 29, 2024 · 0 comments
Open
1 task

Flakiness in TestTransportMultiplexAcceptNonBlocking #1439

staheri14 opened this issue Jul 29, 2024 · 0 comments
Labels
flake A test flake that occurred on Github CI

Comments

@staheri14
Copy link
Contributor

staheri14 commented Jul 29, 2024

Problem

There is flakiness in TestTransportMultiplexAcceptNonBlocking (link) in the main branch.
A sample log for the failure of this in CIs can be found in this link. This is while the same test passes in a local run as well when re-running the job in CI (see this).

--- FAIL: TestTransportMultiplexAcceptNonBlocking (0.04s)
    transport_test.go:350: auth failure: conn.ID (dc5c308702271809cba742299043b03412c02bec) NodeInfo.ID (29095178cc7b29bbd4ae2c94790cf35981ea60ff) mismatch
FAIL
coverage: 67.7% of statements
FAIL	github.com/cometbft/cometbft/p2p	9.544s
ok  	github.com/cometbft/cometbft/p2p/conn	12.[194](https://github.com/celestiaorg/celestia-core/actions/runs/10149954989/job/28066004736?pr=1430#step:6:195)s	coverage: 89.4% of statements
ok  	github.com/cometbft/cometbft/p2p/pex	16.171s	coverage: 77.5% of statements
ok  	github.com/cometbft/cometbft/p2p/trust	1.041s	coverage: 87.1% of statements
FAIL
Error: Process completed with exit code 123.

Acceptance Criteria

  • Determining the root of flakiness and fixing it.
@staheri14 staheri14 added the flake A test flake that occurred on Github CI label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake A test flake that occurred on Github CI
Projects
None yet
Development

No branches or pull requests

1 participant