[dispatcher] Optimize primary method calculation #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes small optimizations to the process of computing a primary method (namely, to
matching-primary-methodsfunction). The changes are mostly structural – replacing lazy transforms and expensive iteration with eager and optimized counterparts.At first, I was under the impression that the time to construct a method for a dispatch value should not matter because of caching, but here and there in Metabase I find cases where the method is reconstructed – either because the method can't be cached, or in situations like camsaul/toucan2#180. Hence, improving the efficiency of this otherwise cacheable process is still worth doing.