Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Clojure functions that contain metadata with custom FnWithMeta #150

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Replace Clojure functions that contain metadata with custom FnWithMeta #150

merged 4 commits into from
Aug 14, 2024

Commits on Aug 13, 2024

  1. Attempt at widening the arities for multimethod calls 

    There's a lot of `apply`/`RestFn`/`invoke` etc. dynamic call machinery
in Methodical's stack traces. This is an attempt to remove some of it
by going up to 7 direct args for multimethod calls. (And dispatch
functions.)

This hasn't removed much of the `apply` overhead in practice because
`with-meta` on a function wraps it with a naive function subclass that
always does a dynamic call. There are probably still some places that
more dynamic calls are creeping in, but I ran out of time to dig
deeper.

This may not go anywhere until I get back, but I wanted to publish this
just in case.
    @bshepherdson @alexander-yakushev
    bshepherdson authored and alexander-yakushev committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0d04686 View commit details
    Browse the repository at this point in the history

  2. Fix tests after widening arities 

    marg
    @alexander-yakushev
    alexander-yakushev committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3fc564e View commit details
    Browse the repository at this point in the history

  3. Introduce custom FnWithMeta to attach metadata to functions

    @alexander-yakushev
    alexander-yakushev committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6968c26 View commit details
    Browse the repository at this point in the history

  4. Reimplement threaded combinator with explicit first/last separation

    @alexander-yakushev
    alexander-yakushev committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0d75db1 View commit details
    Browse the repository at this point in the history