Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_dict() did not pass key on recursion for sort #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anthonyrocom
Copy link

Added the @key parameter to the self.to_dict so that child nodes are also sorted by the key

Added the @key parameter to the self.to_dict so that child nodes are also sorted by the key
@caesar0301 caesar0301 added the unittests required Tests required for new feature or api. label Dec 1, 2019
Copy link
Author

@anthonyrocom anthonyrocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this parameter which is still missing from this recursive function is still not available in the latest code. Can you approve the changes? It seems the Travis unit tests failed due to some archive that couldn't be downloaded, not that the code improvement failed.

@liamlundy liamlundy self-requested a review March 31, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unittests required Tests required for new feature or api.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants