Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modular Refactor #12

Open
valkyrienyanko opened this issue Apr 27, 2020 · 4 comments
Open

Modular Refactor #12

valkyrienyanko opened this issue Apr 27, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@valkyrienyanko
Copy link

I can clean up index.js by spreading your functions / events across multiple files and folders. For e.g. ready.js message.js could be in a folder called Events. I also noticed your not using dotenv which could make handling secrets more convenient. Let me know if you want this and I'll get started when I have time.
@c3duan
Copy link
Owner

c3duan commented May 6, 2020 •
edited
Loading

Sorry about the late reply. I do think my index.js is a bit clunky and if you are still interested in contributing, feel free to make a pull request. dotenv is also a good idea for handing environmental variables. Thanks for the help and suggestions.

@c3duan c3duan reopened this May 6, 2020
@c3duan c3duan added the enhancement New feature or request label May 6, 2020
@valkyrienyanko
Copy link
Author

Alright I'll get started on it now then.

@valkyrienyanko
Copy link
Author

The number of packages you have is a nightmare, I don't really want to install python so I'll PR over what I have. If you really want to look into modular functionality, take a look at this bot repo.

@valkyrienyanko
Copy link
Author

See #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valkyrienyanko @c3duan