Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing editing IncludeWorkflow in new context window #1972

Open
bruno-f-cruz opened this issue Aug 12, 2024 · 1 comment
Open

Comments

@bruno-f-cruz
Copy link
Contributor

bruno-f-cruz commented Aug 12, 2024

I am not sure how this would exactly work and there is likely an edge case that i am not considering. I will still leave this here as a point of future discussion.

Consider a workflow root. root references a IncludeWorkflow, Foo, which in turn references an IncludeWorkflow: Bar.

When navigating the editor, if one wants to edit Bar, there are currently two choices:

  • Explicitly open Bar from the file dialog
  • Ungroup Foo and Bar, in this order, and override both once done.

Given the proposal for a new editor (#1870), I suggest we consider allowing entering an edit mode for Bar directly through its definition in Foo. One idea would be to open a new root in the tree viewer since the user would technically be editing a new workflow (i.e. from Extensions). The user would then be able to edit Bar and choose (or not) to override the current workflow thus propagating all changes to the workflows that reference Bar (including Foo and, indirectly, root)

@bruno-f-cruz
Copy link
Contributor Author

I just realized that

  • Explicitly open Bar from the file dialog

Is not even a great solution either for nested IncludeWorkflows. Once a new workflow is opened, the project working directory will default to the .bonsai file directory. This action will break the references to the previous Extension folder along with possible references to other assemblies that may be defined in the .cproj file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant