From 64e89354d44ebe0b5752d0c03e13724f6e0d5d62 Mon Sep 17 00:00:00 2001 From: Jacob Weinstock Date: Fri, 3 May 2024 09:41:15 -0600 Subject: [PATCH 1/2] Move back to Go 1.18 in go.mod: We don't seem to have an offical strategy for the Go version in go.mod. I believe that, as a library, we should only bump this version if there are dependencies we use that would require us to move to this version. I don't believe that we have any dependencies that warrant a bump. Signed-off-by: Jacob Weinstock --- go.mod | 2 +- go.sum | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/go.mod b/go.mod index ed7b5cf2..fd656c19 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/bmc-toolbox/bmclib/v2 -go 1.22 +go 1.18 require ( dario.cat/mergo v1.0.0 diff --git a/go.sum b/go.sum index d16a2664..6468f053 100644 --- a/go.sum +++ b/go.sum @@ -88,7 +88,6 @@ golang.org/x/sys v0.12.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.19.0 h1:q5f1RH2jigJ1MoAWp2KTp3gm5zAGFUTarQZ5U386+4o= golang.org/x/sys v0.19.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= golang.org/x/term v0.19.0 h1:+ThwsDv+tYfnJFhF4L8jITxu1tdTWRTZpdsWgEgjL6Q= -golang.org/x/term v0.19.0/go.mod h1:2CuTdWZ7KHSQwUzKva0cbMg6q2DMI3Mmxp+gKJbskEk= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk= gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q= From a4fbf70f3c7537b7773eaa92e1688d6ec239b15c Mon Sep 17 00:00:00 2001 From: Jacob Weinstock Date: Fri, 3 May 2024 09:55:38 -0600 Subject: [PATCH 2/2] Document go.mod version philosophy: This makes official our philosophy and policy for the Go version in go.mod. Signed-off-by: Jacob Weinstock --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index 7a33a765..ce9cb280 100644 --- a/README.md +++ b/README.md @@ -255,6 +255,12 @@ The current bmclib version is `v2` and is being developed on the `main` branch. The previous bmclib version is in maintenance mode and can be found here [v1](https://github.com/bmc-toolbox/bmclib/v1). +## Go version in `go.mod` + +As a library we will only bump the version of Go in the `go.mod` file when there are required dependencies in bmclib that necessitate +a version bump. When consuming bmclib in your project, we recommend always building with the latest Go version but this +should be in your hands as a user as much as possible. + ## Acknowledgments bmclib v2 interfaces with Redfish on BMCs through the Gofish library https://github.com/stmcginnis/gofish